Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56825 )
Change subject: opaque_master: Use new API to register shutdown function ......................................................................
Patch Set 1:
(1 comment)
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/56825/comment/a98ffe4a_6e88d6b2 PS1, Line 497: : return register_opaque_master(&opaque_master_nicintel_ee_82580, eecp); The piece of data, eecp, is only used in shutdown function, and not used as opaque_master data (previously there was NULL passed as opaque_master data). I don't think it is a problem, but please correct me if I am wrong. This doesn't make any change to shutdown flow, because eecp was used as data before and same now. As for other operations (read/write etc), they do not expect any data in flashctx, so they will just ignore eecp.
For future, ideally global state will be removed from this programmer (there is global state here at the moment, I am not changing this). Then, piece of data in opaque_master will actually be used, and eecp will become one of the members of data struct.