Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 )
Change subject: linux_mtd: move global state into programmer data field
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/53947/comment/9457ea37_002214bf
PS1, Line 411: if
missing a space between `if` and opening brace
https://review.coreboot.org/c/flashrom/+/53947/comment/da4f6ed9_0b6d32a1
PS1, Line 417: free(data);
I would like to put the `free(data);` call after the `linux_mtd_init_exit` label, but the handling of `param` would need to be refactored, which is out of the scope of this patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/53947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84
Gerrit-Change-Number: 53947
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sat, 08 May 2021 10:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment