Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Samir Ibradžić. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand() ......................................................................
Patch Set 33: Code-Review+1
(2 comments)
Patchset:
PS33: I am deeply sorry, I somehow tricked myself to believe that this is already merged yet. There is a conflict now and I have spotted a small error. As it was my fault that other, conflicting patches were merged first, I went ahead and did the manual rebase. The error still needs to be addressed though, see inline comment.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/b63204f6_6e0abf51 PS33, Line 290: + cmd->readcnt One tiny mistake left. I also didn't realize this before: The buffer `buf` below is not used for the payload data in the `readcnt` transfer. Instead, the `readarr` buffer passed with the command is used, so we must not add `readcnt` here.
It only became obvious when I tried to remove the single-command ft2232_ spi_send_command() function (CB:55684). It was still used for reads. With `readcnt` removed here, it works without ft2232_spi_send_command()!