David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38673 )
Change subject: [WIP] Add .clang-format to help with patch formatting ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/flashrom/+/38673/5/atapromise.c File atapromise.c:
https://review.coreboot.org/c/flashrom/+/38673/5/atapromise.c@145 PS5, Line 145: msg_pwarn( Not sure why clang-format aligned it this way... Maybe BreakStringLiterals is needed? But in this case the '\n' embedded in the string itself might show up in a weird place.
https://review.coreboot.org/c/flashrom/+/38673/4/board_enable.c File board_enable.c:
https://review.coreboot.org/c/flashrom/+/38673/4/board_enable.c@305 PS4, Line 305: msg_pdbg( More instances of weird alignment of strings as arguments to print functions.
https://review.coreboot.org/c/flashrom/+/38673/4/ich_descriptors.h File ich_descriptors.h:
https://review.coreboot.org/c/flashrom/+/38673/4/ich_descriptors.h@118 PS4, Line 118: uint32_t : 17, freq_read : 3, fastread : 1, freq_fastread : 3, freq_write : 3, AlignConsecutiveBitFields might work in these cases?