Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34413 )
Change subject: flashchips: Fill out support for N25Q/MT25Q chips
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34413/2/flashchips.c@10616
PS2, Line 10616: .block_erase = spi_block_erase_c7,
This is also a N25Q vs MT25Q issue. […]
Also, to be clear, this bug affects the pre-existing N25Q512..3E in addition to the N25Q512..1E that I am adding.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9e8d2c1fc0c09efea7812fa513b45d1a372d06d7
Gerrit-Change-Number: 34413
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Creedon
jcreedon@google.com
Gerrit-Reviewer: Jacob Creedon
jcreedon@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 17:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Creedon
jcreedon@google.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment