Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 )
Change subject: raiden_debug_spi.c: Add protocol based configuration to init ......................................................................
Patch Set 20:
(7 comments)
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@159 PS20, Line 159: /* We too much data. */ Oops
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@211 PS20, Line 211: bugs Where? We might as well fix them
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@659 PS20, Line 659: Configures Configure
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@675 PS20, Line 675: switch space after switch
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@676 PS20, Line 676: case GOOGLE_RAIDEN_SPI_PROTOCOL_V1: : /* : * Protocol V1 is supported by adjusting the max data : * read and write sizes which results in no continue packets. : */ : spi_config->command = send_command_v1; : ctx_data->max_spi_write_count = SPI_TRANSFER_V1_MAX; : ctx_data->max_spi_read_count = SPI_TRANSFER_V1_MAX; : break; : default: : msg_pdbg("Raiden: Unknown USB SPI protocol version = %d", : ctx_data->protocol_version); : return USB_SPI_HOST_INIT_FAILURE; We don't indent case labels, AFAIK
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@729 PS20, Line 729: free(ctx_data); This should go with the patch that added the other `free(ctx_data)` call
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@917 PS20, Line 917: spi SPI