[flashrom-gerrit] Change in flashrom[master]: it85spi.c: Refactor singleton states into reentrant pattern

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )

Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c 
File it85spi.c:

https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c@227 
PS5, Line 227: static int get_data_from_context(const struct flashctx *flash, struct it85spi_data **data)
             : {
             :         if (!flash || !flash->mst || !flash->mst->spi.data) {
             :                 msg_perr("Unable to extract data from flash context.\n");
             :                 return SPI_GENERIC_ERROR;
             :         }
             :         *data = (struct it85spi_data *) flash->mst->spi.data;
             : 
             :         return 0;
             : }
             :
> Consistency is good. […]

In that case, I think inlining in this patch seems reasonable to keep this commit diff down some.