Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34621 )
Change subject: helpers: Implement strndup() for MinGW
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c
File helpers.c:
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@111
PS4, Line 111: if((retbuf = malloc( 1 + maxlen )) != NULL) {
Also here. And no spaces inside the parenteses (i.e. `malloc(1 + maxlen)`).
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If418080bffff1f5961cacf2a300ea9c666682458
Gerrit-Change-Number: 34621
Gerrit-PatchSet: 5
Gerrit-Owner: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 21:03:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment