13 May
2023
13 May
'23
10:11 a.m.
Attention is currently required from: Chen, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 )
Change subject: jlink_spi: add cs=tms option to jlink_spi programmer ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/75011/comment/bf2ec21a_c7c2dff9 PS3, Line 160: tms_buffer
I have tested both cases by changing the wiring of Dupont lines.
Now it's clear to me, thank you. I was worried about the situation when CS is not wired to TMS, but I see that you've fixed that.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 5
Gerrit-Owner: Chen c@jia.je
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Chen c@jia.je
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Sat, 13 May 2023 10:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Chen c@jia.je
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov chat@joursoir.net
Gerrit-MessageType: comment