Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU80B
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi Kan, you uploaded new patchset and seems like all comments are resolved, but you haven't marked them as resolved.
If you done everything and ready for the review, you need to respond to comments and mark them resolved (or you can click Done button on each comment). And then you need to click Reply at the top, to send your replies.
This way I will know for sure that you are happy with your patch and I can review it again.
Thank you!
(and same for the other patch)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83180?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8350f4ba94b4819e6496b9c5fddc8617bc0528b5
Gerrit-Change-Number: 83180
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk
ssunkkan@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Ssunk
ssunkkan@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 02:46:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No