Attention is currently required from: Angel Pons, powpowd@gmail.com. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 )
Change subject: meson.build: Don't depend on getrevision.sh ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62061/comment/0efb5ffe_433f0aad PS3, Line 9: (including : GitHub's auto-generated tarballs and ZIPs)
(Excuse the delay; I wrote these comments immediately, but apparently they were only posted under a […]
Yep, this is a general problem, thanks for fixing it.
We don't officially support Meson for release builds, though (and won't until somebody makes it output the same program as the Makefile). Somebody added it with the best intentions but it's not well maintained.
File meson.build:
https://review.coreboot.org/c/flashrom/+/62061/comment/c3b1a94e_64a4a04f PS3, Line 2: version : run_command('util/getversion.sh', '--version').stdout().strip(),
It's intentional, yes! It makes no functional difference, but is a bit more readable.
It's best to mention such things in the commit message. If not mentioned and not directly related to the description, reviewers won't know if it was only added to the commit by accident.