6 Oct
2021
6 Oct
'21
9:02 p.m.
Attention is currently required from: Ravishankar Sarawadi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 )
Change subject: flashchips: Add support for GigaDevice GD25LR256E ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/644430a7_c8590fed PS1, Line 9: Tested using Servo: reading and writing works. Please add a link to the datasheet.
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/58025/comment/0ed07a45_b19386a2 PS1, Line 403: #define GIGADEVICE_GD25LR256E 0x6719 Please keep the ordering and move it down one more line.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0
Gerrit-Change-Number: 58025
Gerrit-PatchSet: 1
Gerrit-Owner: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Sukumar Ghorai sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Ravishankar Sarawadi ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Comment-Date: Wed, 06 Oct 2021 21:02:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment