Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38705 )
Change subject: ft2232_spi: Enhance csgpiol parameter for FT2232
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Only giving a -1 to draw attention. It's a minor thing, but should be fixed before submitting.
https://review.coreboot.org/c/flashrom/+/38705/1/ft2232_spi.c
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/38705/1/ft2232_spi.c@345
PS1, Line 345: i=0; i<=ngpios;
There should be spaces around these operators.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I645ddaa9852e9995bd2a6764862fda2b2ef0c26b
Gerrit-Change-Number: 38705
Gerrit-PatchSet: 1
Gerrit-Owner: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 21:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment