Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropiate variables with bool ......................................................................
Patch Set 10:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/3c96429e_b49b15ac PS7, Line 872: write_cmd = true;
IMHO, if this was a single "treewide: retype variables as bool where appropriate", I might consider […]
Thanks Angel for your comment! You summarized the situation very good.
To give you all some background about how I came to this patch series: I am reworking the programmer arguments parser and I am thinking about how we can deduplicate more code. Since the idea is to make things more type-aware and also all programmers do pretty much the same thing, many things can be centralized and deduplicated. In other words, the parsing and conversion part can be pretty much moved out of the programmer code to one place. However, it just helps a lot when I see the appropriate types at the variables, since this will be important later when I do the actual rework (hooking the new parser up). So I decided to go over the whole tree instead over just the programmers.
I decided to make multiple commits because I think people wouldn't have been able to review the changes else. Unfortunately these changes are not reproducible. If so, I would have done one single patch.
I rather would like to get this patch series in now and do the variable renaming in a separate patch(-series) later, because this series already has been reviewed by Anastasia and others now and it's ready. So it doesn't matter much if I create a dedicated patch series or update this one. At this point the work has to be done twice, since in both cases I have to (re-)write the commit messages (to mention the renaming) and people need to review everything (again).
I think it's very reasonable to separate both changes. It's a very long patch series and this way reviewers can concentrate on one specific thing, which makes it more easier to review. The renaming changes could be done in a single patch since it should be reproducible.