4 Oct
2019
4 Oct
'19
8:27 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35478 )
Change subject: flashchips.c: Update GD25LQ128C/D from downstream ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
-1 just to draw attention...
https://review.coreboot.org/c/flashrom/+/35478/5/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/35478/5/flashchips.c@a5920 PS5, Line 5920: .unlock = spi_disable_blockprotect_bp4_srwd, /* TODO: 2nd status reg (read with 0x35) */ Something wrong with this? Why remove it?
--
To view, visit https://review.coreboot.org/c/flashrom/+/35478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4358392520507ddbfc654feb49fa982d49db2f28
Gerrit-Change-Number: 35478
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment