Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58561 )
Change subject: Add -W options from Makefile into meson warning_flags
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS2:
I was thinking to use werror option (it is mentioned here https://mesonbuild.com/Builtin-options. […]
+1 for separate patch. This makes it a bit easier to compare with the Makefile as-is.
PS2:
Official doc do not explain what exactly each warning level is doing :\ But I found info here: https […]
I think the intention here by meson is to decouple a little from compiler specific frontend flags from meaning.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25
Gerrit-Change-Number: 58561
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 00:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment
