Attention is currently required from: Daniel Campello.
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 )
Change subject: flashrom.c: allow - as filename for stdin/stdout
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
BTW, I just realized this read sizeof("-"), which is two... so I guess it won't act like "starts with".
but you can still drop the "n" in strncmp. strcmp will do just fine here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d
Gerrit-Change-Number: 52383
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Fri, 16 Apr 2021 14:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment