Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: s25f.c: implement probing and block erasers for Spansion
......................................................................
Patch Set 14: -Code-Review
(1 comment)
https://review.coreboot.org/c/flashrom/+/46140/14/chipdrivers.h
File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/14/chipdrivers.h@23
PS14, Line 23: /* for chipaddr and flashctx */
unrelated change, why click Done?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d23f9c36ce8b2959807fbeee7f60e02444e3763
Gerrit-Change-Number: 46140
Gerrit-PatchSet: 14
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Mon, 23 Nov 2020 07:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment