14 Mar
2023
14 Mar
'23
10:22 a.m.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73570 )
Change subject: pcidev: remove pcidev_getdevfn() function ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
PCI access in flashrom is a big mess. […]
Thanks Edward! I didn't cached this. The revert is at CB:73730.
I think the OOP stuff is not necessary. `pacc` is overwritten to make the `rpci_` functions working. When removing the `rpci_` functions and using proper shutdown functions there is no need to have `pacc` globally accessible any longer.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803
Gerrit-Change-Number: 73570
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Mar 2023 10:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment