[flashrom-gerrit] [M] Change in flashrom[master]: ni845x_spi: refactor singleton states into reentrant pattern

[Miklós Márton (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )

Change subject: ni845x_spi: refactor singleton states into reentrant pattern
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> Oh! do you think it was broken by the patch, or at some point earlier? […]

No it got broken earlier. Or maybe something on the mingw make had been changed, it looks that it has issues with the spaces in the linker/include path (which is C:\Program Files-...)

I think I am going to remove the auto detection at all (still keeping it optional), as I doubt that NI will ever change the installation path/method and keep the current path "hardcoded".