28 Apr
2020
28 Apr
'20
8:06 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40626 )
Change subject: Revert "flashchips: port S25FS(128S) chip from chromiumos" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40626/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40626/1//COMMIT_MSG@11 PS1, Line 11: most
I was able to locally reproduce the failure with a Winbond, Thanks for picking this up quickly! […]
This is why I never reviewed it. I can't keep my attention span over such a large change...
--
To view, visit https://review.coreboot.org/c/flashrom/+/40626
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2a4593bdb654f8a26957d69d52189ce61621d93
Gerrit-Change-Number: 40626
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Samir Ibradžić sibradzic@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Apr 2020 20:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment