21 Nov
2023
21 Nov
'23
11:24 a.m.
Attention is currently required from: Anton Samsonov, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email )
Change subject: Makefile: Fix version string for non-Git builds ......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/79152/comment/d7eed972_8759ba85 : PS2, Line 395: ifneq ($(VERSION_GIT),) Does this work properly when `VERSION_GIT` is not defined?
--
To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
Gerrit-Change-Number: 79152
Gerrit-PatchSet: 2
Gerrit-Owner: Anton Samsonov devel@zxlab.ru
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anton Samsonov devel@zxlab.ru
Gerrit-Comment-Date: Tue, 21 Nov 2023 11:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment