Attention is currently required from: Felix Singer, Nico Huber.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makefile: enable internal programmer for x86 and all linux platforms
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61300/comment/bde59052_b7a6d9ce
PS3, Line 7: Makeile
Make_f_ile
Done
https://review.coreboot.org/c/flashrom/+/61300/comment/3925434b_6200cbf6
PS3, Line 10: for
Remove this
Commit message has changed
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/2979996c_561a95aa
PS5, Line 594: CONFIG_INTERNAL_X86 := yes
Shouldn't it be the other way around, i.e. CONFIG_INTERNAL needs to be […]
The new patchset should fix all this. If libpci is not found, the internal programmer can not be build.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 19 Feb 2022 15:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
