David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43598 )
Change subject: endiantest: Fix #if expression ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/43598/1/endiantest.c File endiantest.c:
https://review.coreboot.org/c/flashrom/+/43598/1/endiantest.c@2 PS1, Line 2: #if defined __FLASHROM_LITTLE_ENDIAN__
What's the difference vs using #ifdef ?
No difference according to https://gcc.gnu.org/onlinedocs/gcc-8.4.0/cpp/Defined.html
I used "#if defined" since that's what we use in the other related files (os.h, archtest.c, platform.h). Actually, I just realized that the other files put parens around the macro name, so I've done that in PS2. Now if only we were consistent with spacing...