Attention is currently required from: Felix Singer.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66662 )
Change subject: it87spi.c: Allow passing programmer_cfg directly
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66662/comment/392a3775_0dbf9ffd
PS6, Line 14: init_superio_ite() probably should be renamed to superio_ite_init().
I would remove that. Doesn't have much to do with the rest of the commit. Though, good point.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I598b1811c9734f41eee205d5a2b51ad8ac79e3ab
Gerrit-Change-Number: 66662
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Sat, 03 Sep 2022 04:35:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment