Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69417 )
Change subject: flashrom_tester: Change the wp_toggle semantics
......................................................................
Patch Set 3:
(1 comment)
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/69417/comment/23a4bdfe_c372dc05
PS3, Line 104: fn wp_toggle(&self, en: bool) -> Result<bool, FlashromError> {
Sorry Nik, somehow I dropped the part where I was changing the libflashrom behaviour too. Took a while to debug that.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia01d612d988e6580a7c5f0fd448ccc319ce9b181
Gerrit-Change-Number: 69417
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 05:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment