Attention is currently required from: Felix Singer, Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59238 )
Change subject: tests: Add comprehensive comment for chip.c
......................................................................
Patch Set 7:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/59238/comment/3d62246a_4b67680e
PS6, Line 24: these
Indeed, `this type` or `these types` (of tests)
"this type", right
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59238
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie498ec55cce8460fc0b2e1fe27254d3a9f763fac
Gerrit-Change-Number: 59238
Gerrit-PatchSet: 7
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 25 Jan 2022 00:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment