Attention is currently required from: Anastasia Klimchuk, Brian Norris.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashrom: Don't throw around "delay 1 second" so lightly
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS1:
I think that recommendation should be captured in some kind of changelog so there's "real" documen […]
Angel's suggestion (on the list) to continue using the delay for `!BUS_NONSPI` seems like a reasonable compromise between safety and wastefulness (and should work for all the programmers that ChromeOS cares about). Do you plan to make that change?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/80807?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie09651fede3f9f03425244c94a2da8bae00315fc
Gerrit-Change-Number: 80807
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Brian Norris
briannorris@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 06 May 2024 03:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Norris
briannorris@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment