Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66654 )
Change subject: tree: Change signature of extract_programmer_param_str() ......................................................................
Patch Set 6:
(1 comment)
File atavia.c:
https://review.coreboot.org/c/flashrom/+/66654/comment/b98f134b_2ff3d675 PS6, Line 148: NULL
For any future patches... […]
Not sure if that would have caught the multiple foot shotguns while unraveling that technical debt. It took multiple developers to spot all the ways the state machine can explode when held the wrong way. However good suggestion and food for thought we definitely need more of these sorts of tactics in our pockets to mitigate fireworks.
I did however try to include some past lessons from this in a similar kind of patch CB:68434 to tries catch different interpretations of NULL means different things depending on which control path you wind up on [see comment in flashrom.c]. I am optimistic that a tree where functions that consume and work on arguments over everything being a singleton closure will be a lot less like playing a game of mine sweeper.
Thank you for thinking about this kind of problem!