Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62894 )
Change subject: ichspi: Rename HSFC_FDBC -> HSFC_FDBC_MASK ......................................................................
Patch Set 4:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62894/comment/67c70ca4_b43a76f8 PS4, Line 508: FDBC
Why this is replaced? Commit title says "Rename HSFC_FDBC -> HSFC_FDBC_MASK" and it doesn't mention FDBC.
see this macro definition
./ichspi.c:454:#define pprint_reg(reg, bit, val, sep) _pprint_reg(bit, reg##_##bit, reg##_##bit##_OFF, val, sep)
Before this CL:
reg -> HSFC bit -> FDBC hence, reg##_##bit => HSFC_FDBC and reg##_##bit##_OFF => HSFC_FDBC_OFF both macros exist
With this CL:
reg -> HSFC bit -> FDBC_MASK hence, reg##_##bit => HSFC_FDBC_MASK and reg##_##bit##_OFF => HSFC_FDBC_MASK_OFF
`HSFC_FDBC_MASK` exists but there is no macro to resolve this symbol `HSFC_FDBC_MASK_OFF`, hence, had to use `_pprint_reg` which is very direct, instead those string addition. ./ichspi.c:453:#define _pprint_reg(bit, mask, off, val, sep) msg_pdbg("%s=%d" sep, #bit, (val & mask) >> off)
Hope this clarifies.