Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34488 )
Change subject: flashchips: Split MT25Q from N25Q ......................................................................
Patch Set 1:
Patch Set 1:
Sorry, run into the sorting trap. We try to enforce a sort order on .vendor, .name in `flashchips.c`, currently. I sup- pose "Micron" comes before "Micron/Numonyx/ST".
Alan, how about adding a simple check for this to the Make- file, that could be checked by Jenkins.
Ugh, I'm kind of surprised at how hard it is to get ordering "right". I didn't mean to create a burden for other devs.
No worries. I actually think that the new ordering is better because it is easier to check automatically. We'd just have to hook that up. Even with the old order, it caused friction. A little less maybe, because we didn't check as much for it ;)
The ordering you see was already present. Can you confirm that this was broken before my patch?