Attention is currently required from: Simon Buhrow, Alan Green, Edward O'Callaghan, Anastasia Klimchuk, Samir Ibradžić.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand()
......................................................................
Patch Set 30: Code-Review+1
(4 comments)
Patchset:
PS30:
This looks pretty good now, thank you!
I'll try to find some time to also perform some tests.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/25da835b_ee78e2c5
PS30, Line 291: <= buffer_size;
Sorry, looks like you copy-pasted from my comment? Needs tabs.
https://review.coreboot.org/c/flashrom/+/40477/comment/34af67c9_db1c43da
PS30, Line 303: * Minimize FTDI-calls by packing as many commands as possible
Nit, the line break just seems odd.
https://review.coreboot.org/c/flashrom/+/40477/comment/60e4105d_c0a15933
PS30, Line 311: ){
Missing space before opening brace.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 30
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Tue, 27 Apr 2021 10:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment