Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/79250?usp=email )
Change subject: docs: Add guideline about Gerrit display names ......................................................................
docs: Add guideline about Gerrit display names
If none of "Full name" or "Display name" is set for a Gerrit account, code reviews emails are sent from "Name of user not set" instead of a user name. It is worth clarifying explicitly in the docs.
Change-Id: I69b6f5c1c56a2798dd156582cb5fa246b2396ab3 Signed-off-by: Anastasia Klimchuk aklm@flashrom.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/79250 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Peter Marheine pmarheine@chromium.org Reviewed-by: Stanislav Ponomarev me@stasponomarev.com --- M doc/dev_guide/development_guide.rst 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stanislav Ponomarev: Looks good to me, but someone else must approve Peter Marheine: Looks good to me, approved
diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 60c5625..247a31a 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -183,6 +183,8 @@ #. Add an e-mail address so that Gerrit can send notifications to you about your patch. #. Upload an SSH public key, or click the button to generate an HTTPS password. +#. After account created, set either "Full name" or "Display name", it is used by Gerrit + for code review emails.
.. _pushing-a-patch: