Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83242?usp=email )
Change subject: flashchips: Add Support for XMC XM25QH512C/XM25QH512D
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS3:
Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July.
https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ7...
I am leaving the comment unresolved, so that not to accidentally submit before the tag.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83242/comment/f7663279_b559f65a?usp... :
PS2, Line 22447: FEATURE_4BA_ENTER_WREN
Same question as in other patch for 512 models, about enter/exit 4-byte
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83242?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ica8ed5eaba2435a9416274b94f633ea40dfeea2f
Gerrit-Change-Number: 83242
Gerrit-PatchSet: 3
Gerrit-Owner: Ssunk
ssunkkan@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Ssunk
ssunkkan@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 20 Jul 2024 08:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
