Attention is currently required from: Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52285 )
Change subject: linux_spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: Thanks for comments! I have created another patch https://review.coreboot.org/c/flashrom/+/52492 to fix all of them (since this one is already merged and I can’t change it). I also “replied” to the comments in the new patch, if anymore changes needed I will do everything in 52492.
File linux_spi.c:
https://review.coreboot.org/c/flashrom/+/52285/comment/c99fd9f5_bda01253 PS3, Line 111: const
Why drop it? […]
Yeah it's a step that I need to do on the way to new API, so it is not entirely reentrant at the moment - but will be!