Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66895 )
Change subject: ft2232_spi.c: Retype variable `clock_5x` with bool ......................................................................
ft2232_spi.c: Retype variable `clock_5x` with bool
Use the bool type instead of an integer for the variable `clock_5x`, since this represents its purpose much better.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c Reviewed-on: https://review.coreboot.org/c/flashrom/+/66895 Reviewed-by: Anastasia Klimchuk aklm@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M ft2232_spi.c 1 file changed, 20 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved
diff --git a/ft2232_spi.c b/ft2232_spi.c index 2971c2e..5b45d7e 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <stdbool.h> #include <stdio.h> #include <strings.h> #include <string.h> @@ -317,7 +318,7 @@ * but the non-H chips can only run at 12 MHz. We disable the divide-by-5 * prescaler on 'H' chips so they run at 60MHz. */ - uint8_t clock_5x = 1; + bool clock_5x = true; /* In addition to the prescaler mentioned above there is also another * configurable one on all versions of the chips. Its divisor div can be * set by a 16 bit value x according to the following formula: @@ -618,7 +619,7 @@
if (ftdic.type != TYPE_2232H && ftdic.type != TYPE_4232H && ftdic.type != TYPE_232H) { msg_pdbg("FTDI chip type %d is not high-speed.\n", ftdic.type); - clock_5x = 0; + clock_5x = false; }
if (ftdi_usb_reset(&ftdic) < 0) {