Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38939 )
Change subject: Install the man file when using meson as a buildsystem
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/38939/2/flashrom.8.tmpl
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/38939/2/flashrom.8.tmpl@43
PS2, Line 43: .TH FLASHROM 8 "@MAN_DATE@" "@VERSION@" "@MAN_DATE@"
Does it make sense to adapt the Makefile rule to replace these explicitly (like meson), for consistency? Otherwise people get very puzzled if either side changes, or one of the symbols get used in a different line.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I881bd5002a842072ce9dadea033c51a2668f9e7c
Gerrit-Change-Number: 38939
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 24 Feb 2020 14:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment