Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38223 )
Change subject: raiden_debug: Add missing .write_aai cb fn
......................................................................
Patch Set 1:
Patch Set 1:
Should this be squashed?
I'd prefer that too. Not much applicable to this short patch
queue, but generally it's a bad idea to let reviewers look
ahead in a queue if issues that they spot are already taken
care of.
yes it is something only the upstream requires hence why separated.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/38223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97d26e7d1f59593d0b85dcea539e70773e0aa513
Gerrit-Change-Number: 38223
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Jan 2020 05:01:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment