Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection
......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63724/comment/922c0678_80abdbe3
PS11, Line 10: has some known and unknown bugs.
The tests are currently a problem when not selecting all programmers. […]
I think for now we can go with bugfixes. probe_variable_size() is more important to throw time on.
unguarded include of libusb.h
‘realtek_mst_write’ defined but not used [-Werror=unused-function]
'linux_spi_fgets’ defined but not used [-Werror=unused-function]
'linux_mtd_fclose’ defined but not used [-Werror=unused-function]
chip.c:(.text.setup_chip+0xf8): undefined reference to `programmer_dummy'
Currently you need at least dummy, one libusb programmer, realtek_mst_spi, linux_mtd and linux_spi to build tests successfully.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1
Gerrit-Change-Number: 63724
Gerrit-PatchSet: 15
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 09 May 2022 07:50:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment