Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: Fix unintialized value passed to function
......................................................................
Patch Set 16:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/8c4468e7_a689578e
PS15, Line 11: value
IMO, "variable is passed" would sound like we're passing a reference […]
Yeah, I agree with Nico. Maybe we can write "a garbage value is passed"
https://review.coreboot.org/c/flashrom/+/62725/comment/6ee095da_f973cbf7
PS15, Line 11: later.
Your intention is missing. Suggestion: […]
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/36e8b775_015a2c5c
PS15, Line 12:
You are also setting dump_layout to NULL. Please mention that too. Suggestion: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d
Gerrit-Change-Number: 62725
Gerrit-PatchSet: 16
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 04:22:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
