Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45674 )
Change subject: realtek_mst_i2c_spi.c: Introduce MCU reset param ......................................................................
Patch Set 6: Code-Review-2
(2 comments)
https://review.coreboot.org/c/flashrom/+/45674/6/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/45674/6/realtek_mst_i2c_spi.c@a429 PS6, Line 429: ret = 0; you cannot remove this because now without the 'reset-mcu' param get_params() will fail which isn't valid.
Better to just put comments on the commit than push over it.
https://review.coreboot.org/c/flashrom/+/45674/6/realtek_mst_i2c_spi.c@a453 PS6, Line 453: /* Ensure we are in a known state before entering ISP mode */ this comment still sort of applies on why there is a pre-amble reset before the spi master gets registered into the dispatch mechanism