Attention is currently required from: Thomas Heijligen.
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: Hi and thanks for your review. I was able to fix two of your suggestions, but I'm exactly sure about what you mean for the kernel detach bit?
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/fc892d1f_cf68d84e PS1, Line 108: static int dirtyjtag_spi_shutdown(void *data)
the usb interface should also be released
Done
https://review.coreboot.org/c/flashrom/+/67878/comment/6455e80e_dd515317 PS1, Line 194: int ret = libusb_init(NULL);
please use an own libusb_contest and not the default ine (NULL), even if other programmera do so. […]
Done
https://review.coreboot.org/c/flashrom/+/67878/comment/87725d0a_f822ac89 PS1, Line 214: ret = libusb_set_auto_detach_kernel_driver(handle, 1);
this function is only available on new libusb versions. […]
Do you mean this one? https://review.coreboot.org/c/flashrom/+/57889/6/ch341a_spi.c