Attention is currently required from: Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt. ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73102/comment/94f20b1f_e4239a72 PS1, Line 7: . nit: no period in commit summary
Patchset:
PS1: Code style is completely different, is this intentional? Are there plans to keep this in sync with musl?
File cli_getopt.c:
PS1: No license?
https://review.coreboot.org/c/flashrom/+/73102/comment/592d869c_5a059e59 PS1, Line 13: #if 0 Hmmmm
File include/cli_classic.h:
https://review.coreboot.org/c/flashrom/+/73102/comment/67e05cbd_003f621e PS1, Line 5: __has_include Interesting, is this standard in the C version we use?