Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67474 )
Change subject: flashrom.c: Make emergency_help_message() static local ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67474/comment/ad365f46_7724e76b PS2, Line 10: agnostic
That was my thought as well. We could move all the *_help_message() functions into […]
The principle idea suggested here is not at all unreasonable and had crossed my mind already however in practical terms is hard to archive due to the lack of coupling between the programmer entry structure and the subsequent use of flashctx in the actual control flow graph.
Since this specific call site of `emergency_help_message()` is the only thing in the way of pealing back the programmer global handle and it is after an erasure anyway maybe the better thing to do here is to just fix the `FIXME` and delete the call site to have the symbol static.
Re-designing the logging framework is somewhat orthogonal to the task of getting a handle on the the `programmer_entry` singleton pattern in `flashrom.c`.
I will push a revised pivot here towards that goal, WDYT?