Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46547 )
Change subject: it85spi.c: Kill off dead code system() hack
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I once tried it85spi on an ITE IT8502E EC, just probing made the laptop power off after a few seconds.
eek yea ok. Thanks for the extra info we should perhaps try to fix it once I can recover time from Chromium deforking. Sounds like we should put a warning in the man page?
The code doesn't run unless one uncomments a function call somewhere.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5761dea48d553b1334eef3c9cf0ad79cedbd7806
Gerrit-Change-Number: 46547
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 19 Oct 2020 12:13:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment