Sergey Alirzaev has posted comments on this change. ( https://review.coreboot.org/28911 )
Change subject: ft2232_spi: add an ability to use GPIO for chip selection
......................................................................
Patch Set 1:
Patch Set 1:
(4 comments)
Just some smaller remarks.
AFAIR it's non-trivial to reset the proper CS bit while keeping the code clear. Also, i'm using the new parameter to choose between different chips while the CS pin is left floating.
--
To view, visit
https://review.coreboot.org/28911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db05619e0d69ad18549c8556ef69225337b1532
Gerrit-Change-Number: 28911
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-Reviewer: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 07 Oct 2018 21:33:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No