Attention is currently required from: Thomas Heijligen, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB 3 XHCI flashing ......................................................................
Patch Set 9:
(4 comments)
Patchset:
PS3:
- Ok, […]
Ok, I added vl805 to meson_options.txt next to usbblaster
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/4755d2e2_475f1c34 PS8, Line 19126: .probe = PROBE_SPI_RDID4,
This should also be an other commit. Can be before this or after.
I'll take it off, but if this is needed, I will just put it into it's own commit for the Pi.
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/5e9f3b30_40301652 PS3, Line 38: static struct pci_dev *dev = NULL;
This was referred to `static struct pci_dev *dev = NULL`, not `dev_entries`. […]
Still lost on what you are trying to say, did you mean flashctx instead of flashxtx? I really hate to ask but can you give a example on what you are trying to say?
https://review.coreboot.org/c/flashrom/+/72057/comment/890141e0_adf3208a PS3, Line 72: uint32_t indata = 0; : unsigned int curwritecnt = 0; : unsigned int curreadcnt = 0;
The ` = 0` is not needed for each of them. A declaration of those variables is sufficient. […]
Fixed. I removed the " = 0;" with ";" instead.