David Hendricks has posted comments on this change. ( https://review.coreboot.org/23864 )
Change subject: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Seems pretty straightforward. Let's get this merged soon.
https://review.coreboot.org/#/c/23864/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23864/1//COMMIT_MSG@7 PS1, Line 7: buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain We'll need to fix up the commit message before merging.
https://review.coreboot.org/#/c/23864/1//COMMIT_MSG@8 PS1, Line 8: Missing Signed-off-by line