Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_client: Add rpmc command support ......................................................................
Patch Set 8:
(2 comments)
File doc/classic_cli_manpage.rst:
https://review.coreboot.org/c/flashrom/+/84840/comment/d67204e8_05fca319?usp... : PS7, Line 329: : RPMC commands : ^^^^^^^^^^^^^
Perhaps you can add a little intro which mentions that commands are available only if chip model sup […]
Done
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/84840/comment/fc5dc377_535149a4?usp... : PS4, Line 581: rpmc_ctx
Ah, I think I understand now (also after reading CB:84934 with implementation). […]
Yeah as of now the only way to use the rpmc comands is to set `-c "SFDP-capable chip"` manually. That is also what I did for testing. I think for vendors that still have enough ids to give special ones to rpmc capable devices, we can just or the FEATURE_FLASH_HARDENING bit and set the struct rpmc_ctx values accordingly.
In the beginning I also thought about extending the probe function to also probe for rpmc capabilites or adding a new capability check to set feature bits. That seemed like a lot of hard to test changes, but it might be worth it for the future.
But I'm not sure how the future of flashrom should look like. If maintaining a complicated flashchips.c is worth it, when most of the information can also be parsed from sfdp pages (for newer flashchips).