Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 )
Change subject: layout: Introduce layout_next() ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/33542/2/layout.c File layout.c:
https://review.coreboot.org/c/flashrom/+/33542/2/layout.c@274 PS2, Line 274: : const struct romentry *layout_next_included( : const struct flashrom_layout *const layout, const struct romentry *iterator) : { : while ((iterator = layout_next(layout, iterator))) { : if (iterator->included) : break; : } : return iterator; : } Maybe move this above _layout_next to align with the header file
https://review.coreboot.org/c/flashrom/+/33542/2/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/33542/2/libflashrom.c@351 PS2, Line 351: chip_entry = layout_next(&chip_layout->base, chip_entry); : dump_entry = layout_next(&dump_layout.base, dump_entry); Looks weird that one of these uses '->' and the other uses '.'